Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sounds for different events #599

Merged
merged 3 commits into from
Jul 1, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #551

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues, am fixing them

src/components/SideBar/Footer.jsx Show resolved Hide resolved
src/assets/sounds/index.js Outdated Show resolved Hide resolved
@narayan954 narayan954 linked an issue Jul 1, 2023 that may be closed by this pull request
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 93e4a7a into narayan954:master Jul 1, 2023
@Palakkgoyal Palakkgoyal deleted the addSounds branch July 2, 2023 09:08
@Killer2-O
Copy link

@narayan954 Dont give level3 tags to such basic work. it is atmost level2

@narayan954
Copy link
Owner

@narayan954 Dont give level3 tags to such basic work. it is atmost level2

aight mister makes sense, anyways can I know who're you?

@narayan954 narayan954 added level2 and removed level3 labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a bell sound whenever an event occurs
3 participants