-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize favorites page fetch requests #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
favourite page is giving error, can you try fixing that?
Uncaught TypeError: Cannot destructure property 'caption' of 'post' as it is undefined
Okay. Going to fix these bugs. |
Hey @narayan954 I fixed the console.log and also given a default value to the savedPostsArr but, I am not getting any error as you said related to caption. |
reviewing :) |
|
some posts are undefined, maybe that's because they're deleted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Okay, got that its very necessary to check every aspect of code. |
yes! :) |
This PR closes issue no. #607
You can check the optimization by: