Create a better UI for notification page #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narayan954
approved these changes
Jul 5, 2023
| @@ -57,7 +57,7 @@ const SignupScreen = () => { | |||
| if (!regex.test(name)) { | |||
| setUsernameAvailable(false); | |||
| } else { | |||
| debounce(findUsernameInDB); | |||
| debounce(findUsernameInDB()); | |||
There was a problem hiding this comment.
aren't we passing function reference to the debounce function instead of actually calling the function?
|
Yes, I did this intentionally, cause I checked that the debounce function is not calling the findUsername function. It was just a quick fix but, we need to make it correct. |
It's correct now, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue no. #636
The badge above shows the number of notifications.
I have given styling to the name of friend-request sender. But, that will not show up in this notif as I have updated the notif doc and make it such that it will recieve the sender name seperately so that user can click on it and check their profile and the notif in the screenshot is based on old doc.