like function implemented

[prateek565]

fixes #41

[mathiasayivor]

Sorry, I'm unavailable atm, but would review as soon as I'm back

[narayan954]

It's okay @mathiasayivor

[mathiasayivor]

What's the purpose of this though?

[mathiasayivor]

@prateek565 I've left some comments on the changes, but in summary:

• Replace user.email with user.id since users can update their emails at any point in time
• Avoid mutating component props directly; Clone/copy the prop first
• Use updater functions to make updates reliable
• Re-structure Post.jsx props

[prateek565]

Okay i will get it done by today. Thanks for feedback

[prateek565]

Hi @mathiasayivor I have implemented all the mentioned changes except setLikesno(likesno+1); as this is just a counter and a use state hook which help to show likes fastly as soon as like button is clicked .

[mathiasayivor]

LGTM! Great job @prateek565!
One more thing though,
Based on Post.jsx line 64 if (user && likecount !== undefined) {, does it mean older posts cannot be liked?
was thinking we could add the likecount field if it doesn't exist else users would not be able to like older posts

[prateek565]

Yeah older posts cant be liked as they dont have likecount in their database . as i cant change database i have discussed this with @narayan954 he said he will remove older posts.

This is what he said

I have some cleanup to do i guess. Or you can have a condition for older post where post without likecount field wont be bothered while displaying likes

[mathiasayivor]

Yeah older posts cant be liked as they dont have likecount in their database . as i cant change database i have discussed this with @narayan954 he said he will remove older posts.

Is it not possible to add fields to a firebase doc dynamically?

[prateek565]

Yeah older posts cant be liked as they dont have likecount in their database . as i cant change database i have discussed this with @narayan954 he said he will remove older posts.

Is it not possible to add fields to a firebase doc dynamically?

I have no idea about that i know it can be done by admin who have acess to firestore

[mathiasayivor]

Yeah older posts cant be liked as they dont have likecount in their database . as i cant change database i have discussed this with @narayan954 he said he will remove older posts.

Is it not possible to add fields to a firebase doc dynamically?

I have no idea about that i know it can be done by admin who have acess to firestore

Well, I think it's possible with setDoc. But @narayan954 can still delete the old posts as suggested to free up some space

[mathiasayivor]

LGTM

[narayan954]

Thanks a lot for your contribution :)
Sorry I was unavailable yesterday

[prateek565]

Thanks I was able to learn a lot of new things with this project 😊.

[narayan954]

So good to hear that!!

[narayan954]

It was all due to @mathiasayivor , I am really thankful to him.