Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributor page and fix some minor issues #688

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

SubhamB2003
Copy link
Contributor

issue solved: #648

Contributor.1.mp4

I also fix some minor issues in the setting the About page and privacy and policy page link are incorrect. I also fixed this

@narayan954
Copy link
Owner

Thanks @SubhamB2003 reviewing

@narayan954 narayan954 linked an issue Jul 6, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

Also, as a tip... @SubhamB2003 if you write something like solves #648 instead of issue solved: #648 in the pull request comment, you can directly link your issue to the pull request :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes have been made by me, rest we can do later. For now, do resolve the conversations

src/components/SettingsComponents/Sidebar/index.jsx Outdated Show resolved Hide resolved
src/components/SettingsComponents/Sidebar/index.jsx Outdated Show resolved Hide resolved
src/pages/FooterPages/ContributorPage/index.css Outdated Show resolved Hide resolved
@narayan954 narayan954 merged commit 208664a into narayan954:master Jul 6, 2023
@narayan954 narayan954 added level2 and removed level1 labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Contributor page
2 participants