Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in form ui + buttons for signup and login form both #821

Merged
merged 13 commits into from
Jul 15, 2023

Conversation

akanksha984
Copy link
Contributor

image
image
image
image

I have updated the ui of buttons as well as for form, also, I have done it for both signIn and signUp form in dark and light mode both. Hope you like it @narayan954

Issue reference to : #799
#800

@akanksha984 akanksha984 mentioned this pull request Jul 15, 2023
4 tasks
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akanksha984 can you please check the responsiveness as it's breaking for mobile devices now :/
imageimage

Also, oauth buttons are not centered
image

@akanksha984
Copy link
Contributor Author

image
image
image
image

@narayan954 please check it now I have fixed it

@narayan954
Copy link
Owner

image image image image

@narayan954 please check it now I have fixed it

aight!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

This was linked to issues Jul 15, 2023
@narayan954 narayan954 merged commit 11c393f into narayan954:master Jul 15, 2023
@narayan954
Copy link
Owner

narayan954 commented Jul 15, 2023

Thanks for your contribution!
btw I couldn't find much improvements/changes in buttons and input fields that's why I'm grading this as level 2

@akanksha984
Copy link
Contributor Author

akanksha984 commented Jul 15, 2023

Should I work more upon the ui of the button ? For the input fields I have changed the color according to the theme so, I found it good, and for button there was of lot of confusing going with the theme so i made some changes to it @narayan954

@narayan954
Copy link
Owner

Should I work more upon the ui of the button ? For the input fields I have changed the color according to the theme so, I found it good, and for button there was of lot of confusing going with the theme so i made some changes to it

It's okay for now, we'll look into that later

@akanksha984
Copy link
Contributor Author

Ok sir as you wish 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Sign up form improvement Ui of button and input field improvement
2 participants