-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement in form ui + buttons for signup and login form both #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akanksha984 can you please check the responsiveness as it's breaking for mobile devices now :/
@narayan954 please check it now I have fixed it |
aight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Thanks for your contribution! |
Should I work more upon the ui of the button ? For the input fields I have changed the color according to the theme so, I found it good, and for button there was of lot of confusing going with the theme so i made some changes to it @narayan954 |
It's okay for now, we'll look into that later |
Ok sir as you wish 😊 |
I have updated the ui of buttons as well as for form, also, I have done it for both signIn and signUp form in dark and light mode both. Hope you like it @narayan954
Issue reference to : #799
#800