Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change theme color #837

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[FEATURE] Change theme color #837

merged 3 commits into from
Jul 18, 2023

Conversation

BhartiNagpure
Copy link
Contributor

@BhartiNagpure BhartiNagpure commented Jul 16, 2023

#818 Change theme color

close #818

In this I am change the whole theme color of app .
also solve minor bug that is soundsetting route and apply active tab CSS in setting page.

I think you loved this theme.
Screenshot 2023-07-16 122528

Screenshot 2023-07-16 122512

@BhartiNagpure
Copy link
Contributor Author

@narayan954 I'm done with my work please review it.

@narayan954
Copy link
Owner

Thank you! Reviewing!

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little syntax error,fixing that and checking

src/components/Post/index.jsx Show resolved Hide resolved
@narayan954
Copy link
Owner

@narayan954 I'm done with my work please review it.

I think there was a merge conflict and while solving the merge conflict you missed some syntax, hence there's an syntax error in the app, I'll be reverting the merge commit to fix it cleanly! :)

@BhartiNagpure
Copy link
Contributor Author

@narayan954 check now is there any issue.

@narayan954
Copy link
Owner

@narayan954 check now is there any issue.

i was resolving/merging it :/ anyways, checking again

@narayan954
Copy link
Owner

let me resolve this one

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit c30fe4c into narayan954:master Jul 18, 2023
@narayan954
Copy link
Owner

Thanks for your contribution! :)

@BhartiNagpure BhartiNagpure deleted the bharti branch July 18, 2023 10:21
@BhartiNagpure BhartiNagpure restored the bharti branch July 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Change theme
2 participants