-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit profile #935
Edit profile #935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
8f50018
to
9609bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking........
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I'm not sure, if this should be level 2 or 3 ;-; |
I think it should be level3 cause adding a bio feature only is level2 and previewing image is also level2. Apart from that I added an extra field of location and also made all of them editable. |
fair enough :) |
This PR closes #313
In this I have created a new component that let the user edit their whole profile and I have also added some extra fields such as bio and country. It also shows preview of image so that it become easy for user to select and user do not need to reload the page for checking the changes.