Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit profile #935

Merged
merged 9 commits into from
Jul 24, 2023
Merged

Edit profile #935

merged 9 commits into from
Jul 24, 2023

Conversation

Palakkgoyal
Copy link
Contributor

@Palakkgoyal Palakkgoyal commented Jul 24, 2023

This PR closes #313
In this I have created a new component that let the user edit their whole profile and I have also added some extra fields such as bio and country. It also shows preview of image so that it become easy for user to select and user do not need to reload the page for checking the changes.
Screenshot (621)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954 narayan954 force-pushed the editProfile branch 2 times, most recently from 8f50018 to 9609bfd Compare July 24, 2023 19:53
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking........

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 added level2 and removed level3 labels Jul 24, 2023
@narayan954
Copy link
Owner

I'm not sure, if this should be level 2 or 3 ;-;

@narayan954 narayan954 merged commit 4f2b052 into narayan954:master Jul 24, 2023
@Palakkgoyal
Copy link
Contributor Author

I think it should be level3 cause adding a bio feature only is level2 and previewing image is also level2. Apart from that I added an extra field of location and also made all of them editable.
What is your views on it @narayan954 ?

@Palakkgoyal Palakkgoyal deleted the editProfile branch July 25, 2023 06:03
@narayan954
Copy link
Owner

I think it should be level3 cause adding a bio feature only is level2 and previewing image is also level2. Apart from that I added an extra field of location and also made all of them editable.
What is your views on it @narayan954 ?

fair enough :)

@narayan954 narayan954 added level3 and removed level2 labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Changes in Profile and Create Post tab.
2 participants