Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Toolchain upgrade #5

Merged
merged 1 commit into from
Aug 24, 2022
Merged

[WIP] Toolchain upgrade #5

merged 1 commit into from
Aug 24, 2022

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Aug 24, 2022

fix #3

  • use latest @wordpress/scripts standard
  • no custom config/scripts for compilation
  • standard file naming/directories
  • standard block.json and registration method
  • Divide by 10 the amount of boilerplate/toolchain code

@drzraf
Toolchain upgrade
3a0ca93 
- use latest @wordpress/scripts standard
- no custom config/scripts for compilation
- standard file naming/directories
- standard block.json and registration method
- Divide by 10 the amount of boilerplate/toolchain code
@drzraf drzraf changed the title Toolchain upgrade [WIP] Toolchain upgrade Aug 24, 2022
@narinder9 narinder9 merged commit 3ac7853 into narinder9:main Aug 24, 2022
@drzraf
Copy link
Contributor Author

drzraf commented Aug 24, 2022

Thanks for the quick merge, but I still needed to test it some more locally, thus the "WIP".
I'll let you know if it needs further work (will open a subsequent PR)

drzraf added a commit to drzraf/story-timeline-block that referenced this pull request Aug 25, 2022
@drzraf
- fix PHP/react bugs as part of narinder9#5
47d908c 
- revert block type to the historical value to avoid breaking existing setup
  * cp-timeline/content-timeline => cp-timeline/content-timeline-block
  * cp-timeline/content-timeline-child => cp-timeline/content-timeline-block-child
  (WordPress/gutenberg#42712 may help future transitions)
- better stick to WPGB standards and make cool-timeline-block truly multi-blocks
@drzraf drzraf mentioned this pull request Aug 25, 2022
Merged
@drzraf drzraf mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

outdated build-time dependencies
2 participants
@drzraf @narinder9