Add blocks.migrateBlockType hook #42712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +9 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
retrofox
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
talldan
reviewed
Jul 27, 2022
|
Maybe something general like |
gziolo
added
[Feature] Block API
renamed to |
|
There is still an issue with code formatting reported by Prettier.
I'm still not sure what name would work best. I did another check in the code, and we are really dealing with blocks parsed from the saved content or supplied as the initial state of an inner blocks group. So we don't operate on the block type definitions but on the processed list of blocks here. @dmsnell or @mcsf do you have any suggestions on what name would work best here? |
👍 |
retrofox
changed the title
13 tasks
|
|
On the server, we use There is also a related filter used during block rendering: Anyway,
It's an implementation detail. I don't think it matters that much. In both places, we need to map the block parsed to its new version expected. It's mostly about changing the name of the block, but sometimes it gets a new attribute to retain the ability to distinguish variations when multiple block names were used, for example, in the case of the Embed block. |
drzraf
added a commit
to drzraf/story-timeline-block
that referenced
this pull request
Aug 25, 2022
- revert block type to the historical value to avoid breaking existing setup * cp-timeline/content-timeline => cp-timeline/content-timeline-block * cp-timeline/content-timeline-child => cp-timeline/content-timeline-block-child (WordPress/gutenberg#42712 may help future transitions) - better stick to WPGB standards and make cool-timeline-block truly multi-blocks
|
I wanted to surface this comment #40749 (comment) from @mcsf added after this PR got created based on the original branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fallback PR of #40749.
The changes suggested there are very valid, and it's possible that we'd like to merge with trunk.
What?
This PR adds the
blocks.convertLegacyBlockNameAndAttributeshook to be able to filter the name and/or attributes of the block. The bound function to the hook will run both at the parser level for previous content and to convert such blocks used in Custom Post Types templates.Take advantage of it, for instance, to convert legacy blocks to their canonical form:
Please, take a look at #40749 PR and its comments to know a bit more about the implementation.