Alternating sides, fix #2 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- revert block type to the historical value to avoid breaking existing setup * cp-timeline/content-timeline => cp-timeline/content-timeline-block * cp-timeline/content-timeline-child => cp-timeline/content-timeline-block-child (WordPress/gutenberg#42712 may help future transitions) - better stick to WPGB standards and make cool-timeline-block truly multi-blocks
|
Thanks for your contribution, I'll check and merge it. If you have a WordPress profile then share it with us, we will add code credits inside WP plugin readme file. |
|
I marked this one #9 is ready to be merged, but not this one yet. |
drzraf
force-pushed
the
alternating-sides
branch
from
4e7e058
to
75630b2
Compare
drzraf
force-pushed
the
alternating-sides
branch
from
75630b2
to
6a7bd08
Compare
Signed-Off: Robin Schülein (@sque89)
drzraf
force-pushed
the
alternating-sides
branch
from
6a7bd08
to
83eba1c
Compare
|
The feature was reworked (thx @sque89) => ready for review and merge from our PoV. (Note: This include #9, which itself was a due leftover from #5) There is a minimal number of whitespaces/indentation changes here and there but probably acceptable given the very irregular current formatting. We could solve that later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, don't merge