Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up of #5 #9

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Follow-up of #5 #9

merged 2 commits into from
Oct 18, 2022

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Aug 25, 2022

  • Fix remaining PHP/react bugs as part of [WIP] Toolchain upgrade #5
  • Revert block type renaming to the historical values in order to avoid breaking existing setup
  • Better stick to WPGB standards and make cool-timeline-block truly multi-blocks

- revert block type to the historical value to avoid breaking existing setup
  * cp-timeline/content-timeline => cp-timeline/content-timeline-block
  * cp-timeline/content-timeline-child => cp-timeline/content-timeline-block-child
  (WordPress/gutenberg#42712 may help future transitions)
- better stick to WPGB standards and make cool-timeline-block truly multi-blocks
@drzraf drzraf changed the title Follow-up of #5 [WIP] Follow-up of #5 Aug 25, 2022
@drzraf drzraf changed the title [WIP] Follow-up of #5 Follow-up of #5 Aug 25, 2022
@drzraf
Copy link
Contributor Author

drzraf commented Aug 25, 2022

Added back the missing reference to InnerBlocks.Content inside includes/cool-timeline-block/src/story-timeline/save.js
mergeable

@drzraf drzraf mentioned this pull request Aug 26, 2022
@drzraf
Copy link
Contributor Author

drzraf commented Aug 30, 2022

friendly ping :)

@narinder9 narinder9 merged commit b069a74 into narinder9:main Oct 18, 2022
@drzraf drzraf mentioned this pull request Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants