Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "interchange"-level support for libraries which implement the interchange protocol #517

Merged
merged 23 commits into from
Jul 14, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jul 13, 2024

closes #388

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Maybe from_native should return a SimpleFrame here, with which you can't really do much other than inspect metadata - but then at least the IDE won't autocomplete things it doesn't support

@github-actions github-actions bot added the enhancement New feature or request label Jul 13, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 14, 2024 15:07
@MarcoGorelli MarcoGorelli changed the title feat: add "metadata"-level support for libraries which implement the interchange protocol feat: add "interchange"-level support for libraries which implement the interchange protocol Jul 14, 2024
@MarcoGorelli MarcoGorelli merged commit 7644991 into narwhals-dev:main Jul 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define three levels of support
1 participant