Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature support authentication with SSR #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

b5710546232
Copy link

Hi @narze ,

Relate to issue #17
I adde ssr auth, please review :)

@vercel
Copy link

vercel bot commented Oct 18, 2020

@b5710546232 is attempting to deploy a commit to a Personal Account owned by narze on Vercel.

@narze first needs to authorize it.

@b5710546232
Copy link
Author

About firebase-admin,
May be you need to config more environment variable for

  • private key
  • client email

You can walk through Service accounts tab in firebase console

@narze
Copy link
Owner

narze commented Oct 20, 2020

I don't think that using firebase-admin & adding private key on frontend (Next) is a practical idea. Though I'm not sure how other people do it 🤔

@narze
Copy link
Owner

narze commented Oct 20, 2020

Maybe it should be within /pages/api so that the private credentials won't leak

@b5710546232
Copy link
Author

@narze , If we create for api, we still need to use firebase admin for verifying token in backend.

@b5710546232
Copy link
Author

@narze Sorry for misunderstanding, I mean, I will move firebase-admin into /pages/api instead.

@vercel
Copy link

vercel bot commented Oct 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/narze/typeland/54fhxdmry
✅ Preview: Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants