Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAi Labs AUDACITY #373

Merged
merged 8 commits into from
Sep 23, 2022
Merged

USAi Labs AUDACITY #373

merged 8 commits into from
Sep 23, 2022

Conversation

JHPHELAN
Copy link
Contributor

without videos

@Achllle
Copy link
Collaborator

Achllle commented Sep 23, 2022

Awesome, looks great, @JHPHELAN ! Only thing is that the pull request contains two videos of almost 100MB which makes cloning the repo slow. You can drag and drop a video so it's hosted on Github's servers rather than include it in the source code. To do that, navigate to the file in your branch (link, select the pencil button on the top right to edit the file, then drag and drop the video in place. I'd only add one so we can have many builds without the page loading slowly.

Since you have 4 images, you can display those in a 2x2 grid using the table rather than a 4x1 like you have now, but I can help with that if you don't know how.

@JHPHELAN
Copy link
Contributor Author

@Achllle Following examples moved images to 2x2 and made link to Youtube as video was too large to drop. Preview looks ok, hope it translates.

@Achllle
Copy link
Collaborator

Achllle commented Sep 23, 2022

I removed the video files and did some formatting on the table. I also created a thumbnail for the youtube video rather than just displaying the link. I'll merge this in, if you want to make additions, you're welcome to make another PR!

@Achllle Achllle merged commit 6db67dd into nasa-jpl:master Sep 23, 2022
@JHPHELAN
Copy link
Contributor Author

Thanks for the clean-up! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants