Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary use of dynamic memory in unit tests #315

Closed
3 tasks done
skliper opened this issue Aug 18, 2022 · 0 comments · Fixed by #316
Closed
3 tasks done

Unnecessary use of dynamic memory in unit tests #315

skliper opened this issue Aug 18, 2022 · 0 comments · Fixed by #316
Assignees
@skliper
Labels
draco-rc3 unit-test Related to coverage or functional tests
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Aug 18, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Dynamic memory used in UT for cf_crc and cf_clist.

Describe the solution you'd like
Refactor/simplify.

Describe alternatives you've considered
None

Additional context
Note this will also fix some static analysis warnings w/ the related unit tests.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the unit-test Related to coverage or functional tests label Aug 18, 2022
@skliper skliper added this to the Draco milestone Aug 18, 2022
@skliper skliper self-assigned this Aug 18, 2022
skliper added a commit to skliper/CF that referenced this issue Aug 18, 2022
@skliper
Fix nasa#315, Remove dynamic memory use in UTs
19700c8
@skliper skliper mentioned this issue Aug 18, 2022
Merged
2 tasks
skliper added a commit to skliper/CF that referenced this issue Aug 25, 2022
@skliper
Fix nasa#315, UT update to improve crc initialization check
ae00865
dzbaker added a commit that referenced this issue Aug 25, 2022
@dzbaker
Merge pull request #316 from skliper/fix315-ut_malloc
2776979 
Fix #315, Remove dynamic memory use in UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
draco-rc3 unit-test Related to coverage or functional tests
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #315, Remove dynamic memory use in UTs skliper/CF
2 participants
@skliper @dmknutsen