Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to move files from polling directory instead of delete #373

Closed
3 tasks done
skliper opened this issue Mar 24, 2023 · 1 comment · Fixed by #375
Closed
3 tasks done

Add option to move files from polling directory instead of delete #373

skliper opened this issue Mar 24, 2023 · 1 comment · Fixed by #375

Comments

@skliper
Copy link
Contributor

skliper commented Mar 24, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Only way to send a file without deleting is by command which unnecessarily limits design options.

Intra-app commands isn't ideal, but currently the only option if you want to automate sending files without deleting them. Also nicer for automated data prioritization algorithms to query the number of files in the polling directory (assuming just file count resolution is needed), vs more complex methods of tracking how much data is actually queued via the individual commands, processing CF tlm or similar.

Describe the solution you'd like
Support moving the file from the polling directory instead of always deleting. Possibly rework the keep option to support a move if the move directory is defined (via config) and available. Also useful for commanded cases to just move when done.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Mar 24, 2023

Might help to also have a delete on move fail or keep on move fail option. For the polling directory you'd likely always want to delete, but for a commanded send keeping the file on move fail seems like a valid use case.

@skliper skliper self-assigned this Mar 27, 2023
skliper added a commit to skliper/CF that referenced this issue Mar 27, 2023
skliper added a commit to skliper/CF that referenced this issue Mar 27, 2023
skliper added a commit to skliper/CF that referenced this issue Mar 28, 2023
dzbaker added a commit that referenced this issue Mar 30, 2023
Fix #373, Optionally move files when complete
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants