Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #102, Clean up remaining commented-out code #328

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #102.
Remaining stray 'C++ style' comments (single line // comments) in CF were removed to changed to 'C-style' comments ( /* ).
A few remaining lines of commented out (unused) code were also removed.

Testing performed
None (comment changes only - no code was modified).

Expected behavior changes
No impact on behavior.

Contributor Info
@thnkslprpt

@thnkslprpt thnkslprpt marked this pull request as ready for review October 4, 2022 20:08
@dzbaker
Copy link
Contributor

dzbaker commented Oct 6, 2022

@thnkslprpt CCB 6 October 2022: Approved pending resolution of failed checks.

@thnkslprpt
Copy link
Contributor Author

@thnkslprpt CCB 6 October 2022: Approved pending resolution of failed checks.

Are the CI checks that are failing to build OK to be ignored?
It seems like previous pull requests (that were merged in fine) also failed sometimes at the same point - is it an issue with the action workflow?

@dzbaker
Copy link
Contributor

dzbaker commented Oct 11, 2022

@thnkslprpt CCB 6 October 2022: Approved pending resolution of failed checks.

Are the CI checks that are failing to build OK to be ignored? It seems like previous pull requests (that were merged in fine) also failed sometimes at the same point - is it an issue with the action workflow?

@thnkslprpt It looks like you're right. Something appears to have stopped working in the unit test workflow, although I can't pinpoint a commit that would've caused it. It could be an issue with the workflow, I'm going to look into it. In general, yes, the CI checks could pass (although there are some cases from time to time where the workflow breaks).

@dzbaker dzbaker merged commit 281a941 into nasa:main Oct 18, 2022
@thnkslprpt thnkslprpt deleted the fix-102-comment-clean-up branch October 18, 2022 20:11
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
@ArielSAdamsNASA ArielSAdamsNASA requested review from ArielSAdamsNASA and removed request for ArielSAdamsNASA March 9, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up commented-out functions in unit test
3 participants