Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #336, Apply consistent Event ID names to common events #337

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 21, 2022

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@chillfig
Copy link
Contributor

chillfig commented Mar 9, 2023

CCB:2023.03.09: Putting on hold until naming conventions for event, etc are merged.

@thnkslprpt thnkslprpt force-pushed the fix-336-apply-consistent-event-id-names branch 2 times, most recently from 293cc89 to 0e69115 Compare March 14, 2023 10:10
@thnkslprpt thnkslprpt force-pushed the fix-336-apply-consistent-event-id-names branch from 0e69115 to 06fd1cb Compare May 19, 2023 01:53
@thnkslprpt thnkslprpt force-pushed the fix-336-apply-consistent-event-id-names branch from 06fd1cb to 46c6a66 Compare July 15, 2023 04:49
@dzbaker dzbaker merged commit 08a2e0c into nasa:main Nov 30, 2023
@thnkslprpt thnkslprpt deleted the fix-336-apply-consistent-event-id-names branch November 30, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming
4 participants