Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #416, cleanup cf unused error codes #417

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

avan989
Copy link

@avan989 avan989 commented Nov 27, 2023

Fix #416, clean up cf_cfdp_s.c for unused error code and update unit test

Checklist (Please check before submitting)

Describe the contribution
Fixes #416 clean up unused error code and update unit test

Testing performed
Steps taken to test the contribution:

  1. Make SIMULATION=native install

  2. upload and download using COSMOS ground system

  3. Make SIMULATION=native ENABLE_UNIT_TESTS=true prep

  4. make -j

  5. make test

  6. make lcov

Expected behavior changes
no impact to behavior. error code as always unused.

System(s) tested on

  • ubuntu 22.04

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.

Anh Van, GSFC

Fix nasa#416, clean up cf_cfdp_s.c for unused error code and update unit
test
@dzbaker dzbaker merged commit df516ad into nasa:main Nov 30, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up unused error codes/checks
2 participants