Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Has Unreachable Code and Branches #14

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #36
Closed

CS Has Unreachable Code and Branches #14

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #36

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

CS has several unreachable lines of code and branch conditions.

Unreachable code and branch in CS_AppMain lines 280 - 287:
CS_CreateRestoreStatesFromCDS always returns CFE_SUCCESS.

Unreachable branch in cs_utils.c:CS_BackgroundEeprom line 709:
CurrentEntryInTable is always CS_MAX_NUM_EEPROM_TABLE_ENTRIES when CS_FindEnabledEepromEntry returns false.

Unreachable branches in cs_utils.c:CS_HandleRoutineTableUpdates lines 1037, 1061, 1086:
ErrorCode is always CFE_SUCCESS due to initialization.

Imported from GSFCCFS-1730

astrogeco added a commit that referenced this issue Jun 22, 2022
@skliper skliper added this to the Draco milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant