Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS: Implicit padding being added to definition and results tables #6

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #24
Closed

CS: Implicit padding being added to definition and results tables #6

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #24
Labels
bug draco-rc2
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

Implicit padding is being added to multiple data structures in cs_tbldefs.h.
This creates a problem because we would need to maintain different definition files for decomming the data between our Linux and SP0 systems.

Affected data structures:
CS_Res_App_Table_Entry_t
CS_Res_Tables_Table_Entry_t
CS_Res_EepromMemory_Table_Entry_t
CS_Def_EepromMemory_Table_Entry_t

Imported from GSFCCFS-2020
@skliper skliper added the bug label Apr 22, 2022
@skliper skliper added this to the Draco milestone Apr 22, 2022
dmknutsen added a commit to dmknutsen/CS that referenced this issue Apr 26, 2022
@dmknutsen
Fix nasa#6, remove implicit padding
1309a77
dmknutsen added a commit to dmknutsen/CS that referenced this issue Apr 27, 2022
@dmknutsen
Fix nasa#6, remove implicit padding
1aea2d1
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 2, 2022
@dmknutsen @astrogeco
Fix nasa#6, Apply clang-format
cfdb1cb
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 2, 2022
@dmknutsen @astrogeco
Fix nasa#6, Update documentation, apply clang-format
310f619
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 2, 2022
@dmknutsen @astrogeco
Fix nasa#6, remove implicit padding
1b67a62 
Correct structure definitions to minimize implicit padding added when
running on 64-bit systems.

Update default tables provided to remove positional dependency on table elements.
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 2, 2022
@dmknutsen @astrogeco
Fix nasa#6, Update documentation, apply clang-format
7e8d288
@astrogeco astrogeco mentioned this issue May 2, 2022
Merged
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 3, 2022
@dmknutsen @astrogeco
Fix nasa#6, remove implicit padding from tables
feb8963 
Correct structure definitions to minimize implicit padding added when
running on 64-bit systems.

Update default tables provided to remove positional dependency on table elements.
astrogeco pushed a commit to astrogeco/CS that referenced this issue May 3, 2022
@dmknutsen @astrogeco
Fix nasa#6, Update documentation, apply clang-format
66fd3a5
astrogeco pushed a commit to dmknutsen/CS that referenced this issue May 3, 2022
@dmknutsen @astrogeco
Fix nasa#6, remove padding in table definitions
b32cb44 
Correct structure definitions to minimize implicit padding added when
running on 64-bit systems.

Update default tables provided to remove positional dependency on table elements.
astrogeco pushed a commit to dmknutsen/CS that referenced this issue May 3, 2022
@dmknutsen @astrogeco
Fix nasa#6, Update documentation, apply clang-format
ad5b8dd
astrogeco added a commit that referenced this issue May 4, 2022
@astrogeco
Merge pull request #24 from dmknutsen/main
d076920 
Fix #6, remove implicit padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug draco-rc2
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #6, remove implicit padding dmknutsen/CS
1 participant
@skliper