Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #35, Removes max missed branches #36

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

chillfig
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

Testing performed

  1. lcov --capture --rc lcov_branch_coverage=1 --directory build --output-file coverage_test.info
  2. lcov --rc lcov_branch_coverage=1 --add-tracefile coverage_base.info --add-tracefile coverage_test.info --output-file coverage_total.info
  3. genhtml coverage_total.info --branch-coverage --output-directory lcov

Expected behavior changes
100% code coverage

System(s) tested on

  • Ubuntu 18.04

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal

@skliper
Copy link
Contributor

skliper commented Jul 14, 2022

@dzbaker - looks like this one slipped through. Any ideas on how to catch all PR's that might need to be added to the CCB?

@dzbaker
Copy link
Contributor

dzbaker commented Jul 14, 2022

@skliper That's a good question. It looks like we missed that one because it didn't have a CCB:Ready tag. Perhaps the day before the CCB, I can scan through and look for issues that look ready for the CCB but are missing the tag?

@dzbaker dzbaker merged commit 237385b into nasa:main Jul 20, 2022
@chillfig chillfig deleted the lcov_workflow branch July 21, 2022 15:32
@dmknutsen dmknutsen added this to the Draco milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .github/workflows/unit-test-coverage.yml with no max missed lines or branches
4 participants