Fix #10, Fix nasa/FM#13; Make DS/FM file header sub-types unique #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thnkslprpt
force-pushed
the
fix-ds-10-fm-13-nonunique-subtypes
branch
from
aa23a87
to
c4fec95
Compare
thnkslprpt
force-pushed
the
fix-ds-10-fm-13-nonunique-subtypes
branch
from
c4fec95
to
b038c7b
Compare
thnkslprpt
force-pushed
the
fix-ds-10-fm-13-nonunique-subtypes
branch
from
b038c7b
to
b720fe5
Compare
dmknutsen
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #10 and Fixes nasa/FM#13
Updates
DS_FILE_HDR_SUBTYPEvalue to make it unique (not the same asFM_DIR_LIST_FILE_SUBTYPE).Testing performed
Just GitHub CI actions (incl. build + run).
Expected behavior changes
No impact on behavior.
Contributor Info
Avi Weiss @thnkslprpt