fm_cmd_utils.c has branches that can't be reached (7/7)

[havencarlson]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Looking at code coverage for #17, there are several functions in fm_cmd_utils.c that have else statements that can never be reached. These functions check the return value of FM_GetFilenameState.

Total uncovered here is 7 lines 7 branches.

To Reproduce
Functions with else statements that can never be reached:

• FM_VerifyFileClosed
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 315 to 320 in 51707f2

  	else
  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: filename has unknown state: name = %s, state = %d", CmdText, Filename,
  	FilenameState);
  	}

• FM_VerifyFileExists
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 361 to 366 in 51707f2

  	else
  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: filename has unknown state: name = %s, state = %d", CmdText, Filename,
  	FilenameState);
  	}

• FM_VerifyFileNoExists
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 407 to 412 in 51707f2

  	else
  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: directory name has unknown state: name = %s, state = %d", CmdText, Filename,
  	FilenameState);
  	}

• FM_VerifyFileNotOpen
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 458 to 462 in 51707f2

  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: filename has unknown state: name = %s, state = %d", CmdText, Filename,
  	FilenameState);
  	}

• FM_VerifyDirExists
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 503 to 510 in 51707f2

  	else
  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: directory name has unknown state: name = %s, state = %d", CmdText, Directory,
  	FilenameState);
  	}
  	return (Result);

• FM_VerifyDirNoExists
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 549 to 556 in 51707f2

  	else
  	{
  	CFE_EVS_SendEvent((EventID + FM_FNAME_UNKNOWN_EID_OFFSET), CFE_EVS_EventType_ERROR,
  	"%s error: directory name has unknown state: name = %s, state = %d", CmdText, Name,
  	FilenameState);
  	}
  	return (Result);

Function if an if statement that can't be reached

• SearchOpenFileData
  

  FM/fsw/src/fm_cmd_utils.c

  Lines 150 to 153 in 51707f2

  	if (Fname == NULL)
  	{
  	return;
  	}

Expected behavior
100% coverage

Code snips
See above

System observed on:
CI

Additional context
None

Reporter Info
Haven Carlson, NASA