You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the README file to see if the feature is in the major future work.
I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
The FM_GlobalData object is only used within the FM app for private data storage. It should not be visible externally. However, it is currently defined here in the public fm_msg.h file:
Describe the solution you'd like
This should be defined in one of the internal header files, not in a public interface file.
Additional context
Public API should generally only be constants / #define's, and typedefs. API calls only for libraries - apps do not have public API calls. Extern data structs / globals should not be exposed in either apps or libs for a variety of reasons.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Global data structures should not be defined in the public include
files, they should be private to the local source directory.
Unit test is justified in accessing this file directly, so provisions
are also made to permit this.
Global data structures should not be defined in the public include
files, they should be private to the local source directory.
Unit test is justified in accessing this file directly, so provisions
are also made to permit this.
Global data structures should not be defined in the public include
files, they should be private to the local source directory.
Unit test is justified in accessing this file directly, so provisions
are also made to permit this.
Global data structures should not be defined in the public include
files, they should be private to the local source directory.
Unit test is justified in accessing this file directly, so provisions
are also made to permit this.
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
The
FM_GlobalData
object is only used within the FM app for private data storage. It should not be visible externally. However, it is currently defined here in the publicfm_msg.h
file:FM/fsw/inc/fm_msg.h
Lines 542 to 594 in c856997
Describe the solution you'd like
This should be defined in one of the internal header files, not in a public interface file.
Additional context
Public API should generally only be constants /
#define
's, and typedefs. API calls only for libraries - apps do not have public API calls. Extern data structs / globals should not be exposed in either apps or libs for a variety of reasons.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: