Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size_t for 'size' variables #92

Closed
2 tasks done
thnkslprpt opened this issue Mar 10, 2023 · 0 comments · Fixed by #93
Closed
2 tasks done

Use size_t for 'size' variables #92

thnkslprpt opened this issue Mar 10, 2023 · 0 comments · Fixed by #93

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Most variables representing sizes in FM use size_t.
There are a few that do not follow this custom and could be transitioned over.

Code snips

int32 WriteLength = sizeof(FM_DirListEntry_t);

uint32 FM_GetFilenameState(const char *Filename, uint32 BufferSize, bool FileInfoCmd)

Expected behavior
All size variables that can use size_t should do so - size_t is more expressive and more consistent with the relevant coding guidelines.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 10, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 13, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 14, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 14, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 14, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 16, 2023
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Mar 30, 2023
dzbaker added a commit that referenced this issue Mar 30, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants