Fix #102, Move variables declared mid-function to the top #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-102-move-variables-declared-mid-function
branch
2 times, most recently
from
3ac92f5
to
00ddb8a
Compare
havencarlson
approved these changes
May 12, 2023
|
@thnkslprpt Would you be able to resolve the merge conflict? |
thnkslprpt
force-pushed
the
fix-102-move-variables-declared-mid-function
branch
from
00ddb8a
to
15b99e7
Compare
All cleared up now Dylan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #102
A few stray variables in the test code that were declared mid-function were moved to the top of their respective functions.
Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
All variables declared top of function as per cFS conventions/guidelines - eases future maintenance and improves consistency.
Contributor Info
Avi Weiss @thnkslprpt