Fix #76, Update const-ness of inputs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -157,7 +157,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| uint32 FM_GetFilenameState(char *Filename, uint32 BufferSize, bool FileInfoCmd) | |||
| uint32 FM_GetFilenameState(const char *Filename, uint32 BufferSize, bool FileInfoCmd) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -157,7 +157,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| uint32 FM_GetFilenameState(char *Filename, uint32 BufferSize, bool FileInfoCmd) | |||
| uint32 FM_GetFilenameState(const char *Filename, uint32 BufferSize, bool FileInfoCmd) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long
jphickey
force-pushed
the
fix-76-constness-correct
branch
from
8aa09f3
to
fb8ab6b
Compare
Correct the const qualifiers on functions in fm_cmd_utils.c. Most of these functions do not modify their inputs, but were not const, except for the one function that _was_ marked const and _did_ modify its inputs (backwards).
jphickey
force-pushed
the
fix-76-constness-correct
branch
from
fb8ab6b
to
dbb49a4
Compare
| @@ -242,18 +242,22 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| uint32 FM_VerifyNameValid(char *Name, uint32 BufferSize, uint32 EventID, const char *CmdText) | |||
| uint32 FM_VerifyNameValid(const char *Name, uint32 BufferSize, uint32 EventID, const char *CmdText) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -265,13 +269,14 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| bool FM_VerifyFileState(FM_File_States State, char *Filename, uint32 BufferSize, uint32 EventID, const char *CmdText) | |||
| bool FM_VerifyFileState(FM_File_States State, const char *Filename, uint32 BufferSize, uint32 EventID, | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -265,13 +269,14 @@ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|
|||
| bool FM_VerifyFileState(FM_File_States State, char *Filename, uint32 BufferSize, uint32 EventID, const char *CmdText) | |||
| bool FM_VerifyFileState(FM_File_States State, const char *Filename, uint32 BufferSize, uint32 EventID, | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Correct the const qualifiers on functions in fm_cmd_utils.c. Most of these functions do not modify their inputs, but were not const, except for the one function that was marked const and did modify its inputs (backwards).
Fixes #76
Testing performed
Build and run tests
Expected behavior changes
Nothing visible externally. Message processors no longer modify input buffers.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.