Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #79, generate stubs for internal functions #80

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Regenerate the stubs for fm_child, fm_cmds, and fm_tbl internal units using the UT assert stub generator tool.

Fixes #79

Testing performed
Build and run all tests

Expected behavior changes
None (but see notes)

System(s) tested on
Debian

Additional context
Other APIs have been changed in parallel PRs so those stubs are NOT updated here. Those stubs will be updated with their respective PRs (avoids merge conflict).

This also requires the changes from nasa/osal#1352 in order to deal with the differently-sized return values.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

jphickey commented Feb 9, 2023

Re-pushed identical commit to re-run all tests.

@jphickey
Copy link
Contributor Author

jphickey commented Feb 9, 2023

@dzbaker - as discussed in last week's CCB, this should be OK now that the OSAL update is in place. I re-ran tests and it is passing now.

Regenerate the stubs for fm_child, fm_cmds, and fm_tbl internal units
using the UT assert stub generator tool.
@jphickey
Copy link
Contributor Author

jphickey commented Feb 9, 2023

Latest update removed fm_cmd_stubs.c from this set, because it needs to be with PR #81 (this just avoids a conflict)

@dzbaker dzbaker merged commit 5dc72f5 into nasa:main Feb 9, 2023
@jphickey jphickey deleted the fix-79-use-generated-stubs branch March 7, 2023 16:22
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use generated stubs for all internal functions
4 participants