Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #66, remove static from table definition #82

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Feb 9, 2023

Checklist (Please check before submitting)

Describe the contribution
This is not needed, and it ends up also needing a compiler-specific attribute to avoid a warning. Much simpler without it.

Fixes #66

Testing performed
Build and run all tests

Expected behavior changes
None

System(s) tested on
Debian

Additional context
FSB coding standards restrict use of compiler-specific attributes - should limit to standard ANSI/ISO C. This makes it comply.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

This is not needed, and it ends up also needing a compiler-specific
attribute to avoid a warning.  Much simpler without it.
@dzbaker dzbaker merged commit 5c9d4e8 into nasa:main Feb 9, 2023
@jphickey jphickey deleted the fix-66-table-unstatic branch March 7, 2023 16:22
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove static designation from CFE_TBL_FileDef objects
4 participants