Fix #89, separate msg size verify #94
Conversation
Move the CMD message input size validation to a separate function, so the command handler does not do this itself. This allows the handler to focus on the real message action as opposed to the structure of the message itself.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* FM application -- command packet processor */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void FM_ProcessCmd(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
|
|
||
| bool FM_IsValidCmdPktLength(const CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength, uint32 EventID, const char *CmdText) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| /* FM application -- command packet processor */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void FM_ProcessCmd(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
|
|
||
| void FM_ProcessPkt(const CFE_SB_Buffer_t *BufPtr) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
|
This was reviewed in the 2023-03-23 CCB and approved. The format check error was noted, however this is reporting on a file that did not change in this PR. This is probably a separate issue with the workflow - something is causing it to format these lines inconsistently. |
Checklist (Please check before submitting)
Describe the contribution
Move the CMD message input size validation to a separate function, so the command handler does not do this itself. This allows the handler to focus on the real message action as opposed to the structure of the message itself.
Fixes #89
Testing performed
Build and run all tests. Run FM in CFE and send commands to check behavior.
Expected behavior changes
No impact to behavior - improve source code structure/unit separation only
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.