Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated stubs #82

Closed
3 tasks done
jphickey opened this issue Mar 22, 2023 · 0 comments · Fixed by #83
Closed
3 tasks done

Use generated stubs #82

jphickey opened this issue Mar 22, 2023 · 0 comments · Fixed by #83
Assignees
@jphickey
Labels
Equuleus-rc1 unit-test
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
HS unit testing currently uses a set of stubs for its internal units that are not generated by the tool

Describe the solution you'd like
Use the generated stubs directly whenever possible, as this makes future maintenance easier - when an API changes, just re-run the generator tool to update the stubs.

Additional context
This requires some additional separation of items - global variable stubs should be in a separate compilation unit, as the tool does not generate these.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Mar 22, 2023
jphickey added a commit to jphickey/HS that referenced this issue Mar 22, 2023
@jphickey
Fix nasa#82, use generated stubs
918d27d 
Separate the global variables into separate stub source units, then
re-run the stub generator for all internal APIs. The committed result
here is the exact output of the tool, unmodified.

This eases future maintainence, when an internal API changes one just
needs to re-run the stub generator tool to update it.
@jphickey jphickey mentioned this issue Mar 22, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Mar 23, 2023
@dzbaker
Merge pull request #83 from jphickey/fix-82-generated-stubs
2498601 
Fix #82, use generated stubs
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
Equuleus-rc1 unit-test
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #82, use generated stubs jphickey/HS
3 participants
@jphickey @dmknutsen @chillfig