You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
Depending on where the message definitions came from, and the type of HDR implementation used, the first element of a structure may or may not be named CommandHeader. This is controlled by the specific MsgHdr implementation that was chosen.
To Reproduce
Build the MAT using EDS-generated structs - in these (unfortunately) there is an extra layer of nesting, so this fails. The first element still is ultimately a command header.
Expected behavior
The TBL message definitions are defined by a combination of TBL itself and the MSG HDR module selection. No assumptions in HS should be made about its structure.
Additional context
Should be able to just remove this part of the designated initializer. Normally I would recommend use of designated initializers, but in this context it introduces a dependency/assumption that may not be correct.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Checklist (Please check before submitting)
Describe the bug
Depending on where the message definitions came from, and the type of HDR implementation used, the first element of a structure may or may not be named
CommandHeader
. This is controlled by the specific MsgHdr implementation that was chosen.To Reproduce
Build the MAT using EDS-generated structs - in these (unfortunately) there is an extra layer of nesting, so this fails. The first element still is ultimately a command header.
Expected behavior
The TBL message definitions are defined by a combination of TBL itself and the MSG HDR module selection. No assumptions in HS should be made about its structure.
Code snips
HS/fsw/tables/hs_mat.c
Line 75 in 94098ef
Specifically the ".CommandHeader" part.
System observed on:
Debian
Additional context
Should be able to just remove this part of the designated initializer. Normally I would recommend use of designated initializers, but in this context it introduces a dependency/assumption that may not be correct.
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: