Fix #9, use CFE_MSG_PTR macro #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates all data structures and function names to use the proper naming conventions - that is: - Structure for each command that matches command name - Consistent application of CamelCase and command code name (_CC) This also fixes a few other unsafe/improper casts regarding message buffers.
|
CCB 23 February 2023: Approved pending workflow failure resolution. |
jphickey
force-pushed
the
fix-9-cfe-msg-ptr
branch
from
e3aee45
to
2c84341
Compare
This also fixes additional naming convention issues with the CC macros where some underscores (word separator) were missing.
jphickey
force-pushed
the
fix-9-cfe-msg-ptr
branch
from
2c84341
to
fc92438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This also updates all data structures and function names to use the proper naming conventions - that is:
This also fixes a few other unsafe/improper casts regarding message buffers.
Fixes #9
Testing performed
Build and run all tests, sanity check HS
Expected behavior changes
Safer code, No impact to behavior
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.