Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FRM branch and implemented minor bugfixes #130

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

ARamsay17
Copy link
Contributor

  • Full-FRM branch now correctly propagates Polarisation uncertainty with the Class-based approach. This is a temporary measure until we have a full correction.

  • Full-FRM branch uses correct uncertainties for the Temperature correction from the Characterisation files, before it used the same uncertainty as in the Class-based branch.

  • Specified KeyError for try/except CalibrationFile.py L126. This was catching unexpected errors and masking an issue I was having with the code.

  • Bugfix: 'remove' button for cal files no longer causes a crash if no file is selected.

  • Bugfix: Avoid KeyError when Ancillary data comes from SeaBass file only.

ARamsay17 and others added 6 commits December 7, 2023 12:56
…1A/B - Corrected issues with cT and cPol uncertainties specific to the Full-FRM branch. cPol now propagated for FRM using the class based approach. cT for Full-FRM now propagated using quoted uncertainties from RadChar files instead of class based approach.
…illary data from a seabass file. If GPS file is constructed from Ancillary data it will have a CalFileName of "ANCILLARY" which will cause a key error in ProcessL1b_FactoryCal.py, L204 (or 205 in commit code).
@oceancolorcoder oceancolorcoder merged commit 102c2dc into nasa:dev Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants