Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #53, Remove stray refs to old event type constants #54

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Dec 5, 2022

Checklist

Describe the contribution

Alternative to updating these is to delete these (commented-out) lines.

Either way, the references to the old event types should not remain, as if any of these tests are un-commented-out it will cause a build failure.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No impact on behavior.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-53-update-remaining-refs-to-old-event-type-constants branch from e6b7da4 to 7ceeafc Compare March 14, 2023 11:35
@dzbaker dzbaker requested a review from jphickey April 20, 2023 18:41
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this appears to be all in "commented-out" code blocks. My recommendation is that we should just remove them entirely. In general we discourage having commented-out code in the repo (history is what git is for).

@thnkslprpt
Copy link
Contributor Author

Hmm, this appears to be all in "commented-out" code blocks. My recommendation is that we should just remove them entirely. In general we discourage having commented-out code in the repo (history is what git is for).

Great idea! Who doesn't love deleting superfluous code.

@thnkslprpt thnkslprpt force-pushed the fix-53-update-remaining-refs-to-old-event-type-constants branch 2 times, most recently from e867aee to 904243b Compare May 4, 2023 21:01
@thnkslprpt thnkslprpt force-pushed the fix-53-update-remaining-refs-to-old-event-type-constants branch from 904243b to 689f801 Compare May 4, 2023 21:06
@thnkslprpt thnkslprpt requested a review from jphickey May 4, 2023 21:06
@dzbaker dzbaker merged commit ac13af6 into nasa:main May 18, 2023
@thnkslprpt thnkslprpt deleted the fix-53-update-remaining-refs-to-old-event-type-constants branch May 18, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove remaining stray references to old event types
3 participants