Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8, Remove unnecessary characters from memory dump event #52

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 23, 2022

Checklist

Describe the contribution

Testing performed
Build & Run + Unit Tests.

Expected behavior changes
Increases the number of bytes that can be dumped in the event message string dramatically (by around double, depending on the value that is set for CFE_MISSION_EVS_MAX_MESSAGE_LENGTH).

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt marked this pull request as ready for review November 5, 2022 08:39
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt force-pushed the fix-8-remove-unnecessary-characters-in-dump-event branch 2 times, most recently from d96f62b to 3746982 Compare March 14, 2023 13:21
@thnkslprpt thnkslprpt force-pushed the fix-8-remove-unnecessary-characters-in-dump-event branch from 3746982 to e948cdd Compare April 22, 2023 09:14
@dzbaker dzbaker requested a review from havencarlson May 18, 2023 18:39
@dzbaker dzbaker merged commit df7401f into nasa:main May 25, 2023
@thnkslprpt thnkslprpt deleted the fix-8-remove-unnecessary-characters-in-dump-event branch May 25, 2023 20:03
@dzbaker dzbaker mentioned this pull request Jul 6, 2023
2 tasks
dzbaker added a commit that referenced this pull request Jul 6, 2023
This reverts commit df7401f, reversing
changes made to da7ef70.
@dzbaker dzbaker mentioned this pull request Jul 6, 2023
2 tasks
dzbaker added a commit that referenced this pull request Jul 6, 2023
Fix #77: Revert merge of PR #52.
dzbaker added a commit to dzbaker/MM that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MM_DumpInEventCmd wastes event characters
3 participants