Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Analysis: 'unsigned int' but is of type 'PCS_WIND_TCB *' #251

Open
astrogeco opened this issue Feb 17, 2021 · 2 comments
Open

Static Analysis: 'unsigned int' but is of type 'PCS_WIND_TCB *' #251

astrogeco opened this issue Feb 17, 2021 · 2 comments
Labels
bug Something isn't working security

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Feb 17, 2021

Describe the bug
See https://github.com/nasa/cFS/security/code-scanning/1?query=ref%3Arefs%2Fpull%2F193%2Fmerge

Detected in psp/fsw/mcp750-vxworks/src/cfe_psp_exception.c:208

Not sure we might want to dismiss it

To Reproduce
Run CodeQL

Code snips
Screen Shot 2021-02-17 at 1 14 02 PM

@astrogeco astrogeco added bug Something isn't working security labels Feb 17, 2021
@astrogeco astrogeco assigned jphickey and unassigned jphickey Feb 17, 2021
@skliper
Copy link
Contributor

skliper commented Feb 17, 2021

It's not a cert issue, this would be open source resources please.

@skliper
Copy link
Contributor

skliper commented Feb 17, 2021

Reference is out of date, if you use the static analysis from main: https://github.com/nasa/PSP/security/code-scanning/36?query=ref%3Arefs%2Fheads%2Fmain

and

snprintf(ReasonBuf, ReasonSize, "Vector=0x%06X, vxWorks Task Name=%s, Task ID=0x%08X", Buffer->context_info.vector,
TaskName, Buffer->sys_task_id);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

No branches or pull requests

3 participants