-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17, Use real message types in tables #35
Conversation
CCB:2022-06-08 APPROVED |
5e01cf6
to
c050163
Compare
Marking as draft for now until #62 is merged which will simplify includes |
To test ATS: Output should look something like this:
|
c050163
to
5256fa1
Compare
#define CMD3_TIME (TEST_TIME + 40) | ||
#define CMD4_TIME (TEST_TIME + 100) | ||
/* Checksum for each sample command */ | ||
#ifndef SC_NOOP_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#ifndef SC_NOOP_CKSUM | ||
#define SC_NOOP_CKSUM (0x8F) | ||
#endif | ||
#ifndef SC_ENABLE_RTS1_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#ifndef SC_ENABLE_RTS1_CKSUM | ||
#define SC_ENABLE_RTS1_CKSUM (0x8D) | ||
#endif | ||
#ifndef SC_START_RTS1_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#ifndef SC_START_RTS1_CKSUM | ||
#define SC_START_RTS1_CKSUM (0x8E) | ||
#endif | ||
#ifndef SC_RESET_COUNTERS_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#define CMD2_TIME 5 | ||
#define CMD3_TIME 5 | ||
/* Checksum for each sample command */ | ||
#ifndef SC_NOOP_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#ifndef SC_NOOP_CKSUM | ||
#define SC_NOOP_CKSUM (0x8F) | ||
#endif | ||
#ifndef SC_ENABLE_RTS2_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#ifndef SC_ENABLE_RTS2_CKSUM | ||
#define SC_ENABLE_RTS2_CKSUM (0x8E) | ||
#endif | ||
#ifndef SC_START_RTS2_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
#define CMD2_TIME 5 | ||
#define CMD3_TIME 7 | ||
/* Checksum for each sample command */ | ||
#ifndef SC_NOOP_CKSUM |
Check notice
Code scanning / CodeQL-coding-standard
Conditional compilation
5256fa1
to
1edd226
Compare
This is good to go, only CI failures are unrelated and documented in: |
Checklist (Please check before submitting)
Describe the contribution
Note so far this is just partial/example, is not backwards compatible with Caelum framework and has a dependency on nasa/cFE#2115. Marking as draft for now.
Testing performed
Ran with the cFE changes, confirmed noops were sent/received using the following cmds:
Expected behavior changes
Behavior is the same, just makes table maintenance easier and slightly more portable across different endian systems and w/ different header implementations.
System(s) tested on
Additional context
Depends on cFE update nasa/cFE#2115
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC