Fix #63, Remove initializations causing Cppcheck errors #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #63
Both seem fine to change from initialization at the top of the function to a plain declaration.
TempAtsChar
is used in only one location, and that is after a mutually exclusiveif
/else
which assigns it a value in both cases.IndexDelta
is used inside just oneif
block, and is assigned a value (on line 409) before any of the 3 references to it are made.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on code behavior.
Cppcheck now passes without error again.
Contributor Info
Avi @thnkslprpt