Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #87, Update Command Code underscores for consistency #88

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Apr 17, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Unit Tests and Build + Run).

Expected behavior changes
No change to behavior.
Improved consistency and clarity.

Note: there are similar issues with some of the SC EIDs lacking underscores between words: e.g. SC_ENARTSGRP_CMD_INF_EID

Contributor Info
Avi Weiss @thnkslprpt

Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dzbaker dzbaker merged commit 111cc3b into nasa:main Jun 1, 2023
@thnkslprpt thnkslprpt deleted the fix-87-update-command-code-underscores-for-consistency branch June 1, 2023 21:58
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Code/Enum naming convention inconsistencies
4 participants