title issue in a few early pages - checks for number of center elements and picks different one to find title in #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed _title function in attempt at fixing this bug in finding titl…
This was referenced May 7, 2020
|
Hi Justin, I cloned your fork but there was some issues with running it. There seems to be an extra space on line 121 just before the "else;". If I remove that, then things run OK. After I ran it, I tried several searches in 1995, 1996, 1997, 1999, 2003, 2013, 2015, 2019 and 2020, the titles seemed to display correctly and don't display the "tomorrow's picture" or "Information:"; they seemed to display the right title. For some dates in 1996, there are some existing issues with \r \n popping up with Credit or Credit and Copyright. Not sure if you want to fix those as well in this pr? |
|
@punpunkore can you add that as a separate issue and mention this pull request? I'll merge this one now and close the previous issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs extensive testing across many dates to make sure it doesn't cause more problems than it solves..... Would appreciate it if anyone could clone this fork, test it, and leave comments here!
This potentially fixes #23