Move calls to GetPipeName() to reduce code duplication in BroadcastBufferToRoute()

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
These 3 calls to CFE_SB_GetPipeName() in CFE_SB_BroadcastBufferToRoute() could be reduced to 1 if it was moved up a bit higher to just after the opening of the for loop block.

Code snips

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 1677 to 1733 in 7af467e

	for (i = 0; i < SBSndErr.EvtsToSnd; i++)
	{
	if (SBSndErr.EvtBuf[i].EventId == CFE_SB_MSGID_LIM_ERR_EID)
	{
	/* Determine if event can be sent without causing recursive event problem */
	if (CFE_SB_RequestToSendEvent(TskId, CFE_SB_MSGID_LIM_ERR_EID_BIT) == CFE_SB_GRANTED)
	{
	CFE_SB_GetPipeName(PipeName, sizeof(PipeName), SBSndErr.EvtBuf[i].PipeId);
	CFE_ES_PerfLogEntry(CFE_MISSION_SB_MSG_LIM_PERF_ID);
	CFE_ES_PerfLogExit(CFE_MISSION_SB_MSG_LIM_PERF_ID);
	CFE_EVS_SendEventWithAppID(CFE_SB_MSGID_LIM_ERR_EID, CFE_EVS_EventType_ERROR, CFE_SB_Global.AppId,
	"Msg Limit Err,MsgId 0x%x,pipe %s,sender %s",
	(unsigned int)CFE_SB_MsgIdToValue(BufDscPtr->MsgId), PipeName,
	CFE_SB_GetAppTskName(TskId, FullName));
	/* clear the bit so the task may send this event again */
	CFE_SB_FinishSendEvent(TskId, CFE_SB_MSGID_LIM_ERR_EID_BIT);
	}
	}
	else if (SBSndErr.EvtBuf[i].EventId == CFE_SB_Q_FULL_ERR_EID)
	{
	/* Determine if event can be sent without causing recursive event problem */
	if (CFE_SB_RequestToSendEvent(TskId, CFE_SB_Q_FULL_ERR_EID_BIT) == CFE_SB_GRANTED)
	{
	CFE_SB_GetPipeName(PipeName, sizeof(PipeName), SBSndErr.EvtBuf[i].PipeId);
	CFE_ES_PerfLogEntry(CFE_MISSION_SB_PIPE_OFLOW_PERF_ID);
	CFE_ES_PerfLogExit(CFE_MISSION_SB_PIPE_OFLOW_PERF_ID);
	CFE_EVS_SendEventWithAppID(CFE_SB_Q_FULL_ERR_EID, CFE_EVS_EventType_ERROR, CFE_SB_Global.AppId,
	"Pipe Overflow,MsgId 0x%x,pipe %s,sender %s",
	(unsigned int)CFE_SB_MsgIdToValue(BufDscPtr->MsgId), PipeName,
	CFE_SB_GetAppTskName(TskId, FullName));
	/* clear the bit so the task may send this event again */
	CFE_SB_FinishSendEvent(TskId, CFE_SB_Q_FULL_ERR_EID_BIT);
	}
	}
	else
	{
	/* Determine if event can be sent without causing recursive event problem */
	if (CFE_SB_RequestToSendEvent(TskId, CFE_SB_Q_WR_ERR_EID_BIT) == CFE_SB_GRANTED)
	{
	CFE_SB_GetPipeName(PipeName, sizeof(PipeName), SBSndErr.EvtBuf[i].PipeId);
	CFE_EVS_SendEventWithAppID(CFE_SB_Q_WR_ERR_EID, CFE_EVS_EventType_ERROR, CFE_SB_Global.AppId,
	"Pipe Write Err,MsgId 0x%x,pipe %s,sender %s,stat %ld",
	(unsigned int)CFE_SB_MsgIdToValue(BufDscPtr->MsgId), PipeName,
	CFE_SB_GetAppTskName(TskId, FullName), (long)(SBSndErr.EvtBuf[i].OsStatus));
	/* clear the bit so the task may send this event again */
	CFE_SB_FinishSendEvent(TskId, CFE_SB_Q_WR_ERR_EID_BIT);
	}
	}
	}

Expected behavior
Reduce unnecessary code duplication.

Reporter Info
Avi Weiss @thnkslprpt