Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2090, UT updates for alternate time configuration #2099

Merged
merged 1 commit into from
May 19, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 11, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Build and run unit tests with alternate time configuration:

#define CFE_PLATFORM_TIME_CFG_SOURCE true
#define CFE_PLATFORM_TIME_CFG_SRC_TIME true
#define CFE_MISSION_TIME_CFG_FAKE_TONE false

Confirm it builds, tests pass, and coverage matches (the same 2 lines, 1 branch uncovered in time for either config)

Expected behavior changes
None, just fixes UT for alt time config

System(s) tested on

  • Hardware: i5/wsl
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit w/ alternate time config

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 11, 2022
@skliper skliper added this to the Draco milestone May 11, 2022
@skliper
Copy link
Contributor Author

skliper commented May 11, 2022

Ping @jonathan-brandenburg-metecs @excaliburtb for awareness. This should allow you eliminate the work-arounds in your distribution.

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 11, 2022
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 11, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 11, 2022
@astrogeco
Copy link
Contributor

CCB:2022-05-11 APPROVED

astrogeco added a commit to nasa/cFS that referenced this pull request May 18, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request May 18, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Jonathan Branderburg <jonathan-brandenburg-metecs@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
Co-authored-by: Hugo Valente <HugoValente11@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request May 18, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Jonathan Branderburg <jonathan-brandenburg-metecs@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
Co-authored-by: Hugo Valente <HugoValente11@users.noreply.github.com>
@astrogeco astrogeco merged commit 107dbf5 into nasa:main May 19, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Jonathan Branderburg <jonathan-brandenburg-metecs@users.noreply.github.com>
Co-authored-by: Alan Cudmore <acudmore@users.noreply.github.com>
Co-authored-by: Hugo Valente <HugoValente11@users.noreply.github.com>
@skliper skliper deleted the fix2090-alt_time_config_ut branch June 9, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test won't build with external time source configuration
2 participants