Fix #1466, Add status return to CFE_ES_WaitForStartupSync()

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

• Fixes Add status output to CFE_ES_WaitForStartupSync #1466
  • Converts CFE_ES_WaitForStartupSync() from void return to CFE_Status_t, and carries through the return value from CFE_ES_WaitForSystemState().

Testing performed
GitHub CI actions all passing successfully.
Local tests confirm all tests passing and LCOV confirms coverage of amended lines, and total coverage unaffected.

These 2 UT calls to CFE_ES_WaitForStartupSync() would have had to be updated, but as far as I can tell they are not actually required for coverage, and are not needed for the test blocks that they are part of (ES_ResetUnitTest() is run immediately after both).

cFE/modules/es/ut-coverage/es_UT.c

Lines 4441 to 4463 in 7c03369

	ES_UT_SetupSingleAppId(CFE_ES_AppType_CORE, CFE_ES_AppState_RUNNING, "UT", &UtAppRecPtr, NULL);
	CFE_ES_Global.SystemState = CFE_ES_SystemState_CORE_READY;
	/* Note - CFE_ES_WaitForStartupSync() returns void, nothing to check for
	* here. This is for code coverage
	*/
	UtAssert_VOIDCALL(CFE_ES_WaitForStartupSync(99));
	/* Test waiting for apps to initialize as an external app
	*/
	ES_ResetUnitTest();
	ES_UT_SetupSingleAppId(CFE_ES_AppType_EXTERNAL, CFE_ES_AppState_EARLY_INIT, "UT", &UtAppRecPtr, NULL);
	CFE_ES_Global.SystemState = CFE_ES_SystemState_CORE_READY;
	/* Note - CFE_ES_WaitForStartupSync() returns void, nothing to check for
	* here. This is for code coverage
	*/
	UtAssert_VOIDCALL(CFE_ES_WaitForStartupSync(99));
	/* Test successfully adding a time-stamped message to the system log that
	* causes the log index to be reset
	*/
	ES_ResetUnitTest();

Coverage is already provided by the prior call to CFE_ES_WaitForStartupSync():

cFE/modules/es/ut-coverage/es_UT.c

Line 4434 in 7c03369

CFE_ES_WaitForStartupSync(0);

CFE_ES_WaitForSystemState() is already fully covered elsewhere.

Expected behavior changes
CFE_ES_WaitForStartupSync() now carries through the status/return of CFE_ES_WaitForSystemState() allowing additional handling by the user.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

[github-advanced-security]

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 1905 existing alerts. Please check the repository Security tab to see all alerts.

[github-advanced-security]

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

[jphickey]

Looks good