Fix #2421, adjust dependencies on table lib #2422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Instead of having the intermediate table library build as part of the "all" target, attach it as a dependency under the custom rule. This way it will only be built in the context of the cfetables top level target, not both.
Fixes #2421
Testing performed
Build a configuration with lots of tables (> 100) repeatedly from a clean start using various
-j
values.Expected behavior changes
Builds succeed, no race conditions/sporadic failures.
System(s) tested on
Debian
Additional context
This excludes the intermediate library from the
all
target and instead attaches it explicitly under the generate tables rule. So it should avoid the case of having two legs of a parallel build both finding the dependency and attempting to build it.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.