Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-09-02 #136

Merged
merged 9 commits into from
Sep 9, 2020
Merged

Integration Candidate: 2020-09-02 #136

merged 9 commits into from
Sep 9, 2020

Conversation

yammajamma
Copy link
Contributor

@yammajamma yammajamma commented Sep 3, 2020

Describe the contribution
Integration candidate includes:

nasa/cFE#861
nasa/osal#590
nasa/cFS-GroundSystem#133

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/136/checks

Expected behavior changes
See PRs.

System(s) tested on
Ubuntu - CI

Additional context
None.

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Joseph Hickey, Vantage Systems, Inc.
Chris Knight, NASA-ARC

@skliper
Copy link
Contributor

skliper commented Sep 4, 2020

Traced it to a TTF, which is actually mis-categorized since the context isn't right... and turns out TTF's don't get summarized so very easy to miss. EVTCNT(3) when events are 4, likely due to not resetting the event counts...

@jphickey
Copy link
Contributor

jphickey commented Sep 8, 2020

I believe the hotfixes have fixed the documentation issues, but the SB unit test failure remains:

68/76 Test #68: cfe-core_sb_UT ....................***Failed    0.03 sec

This is probably the issue currently blocking the build.

@yammajamma
Copy link
Contributor Author

@skliper could you take a look at why SB unit test is still failing despite the hotfix?

@skliper
Copy link
Contributor

skliper commented Sep 8, 2020

This looks to me like an actual change in behavior... where 4 events are now being created as part of the test vs 3. Not sure yet what changed. Previously this test only actually created 3 messages (there was a bug in that it wasn't clearing the event count prior to this test). It'll take some digging.

@jphickey
Copy link
Contributor

jphickey commented Sep 8, 2020

Looks like this is finally passing CI successfully...!

@yammajamma yammajamma merged commit 9f0b3ad into main Sep 9, 2020
chillfig pushed a commit to chillfig/cFS that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants