-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #554, Updated ubuntu version in CI workflows #559
Conversation
Could also use "ubuntu-latest" so we don't have to update the workflows every time a new version comes out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I actually prefer explicit 22.04 for elements that are most likely to be impacted by updates so we have better control over when the update happens (vs a surprise when GitHub updates their ubuntu-latest). Is there a matching set of updates in the submodules for any changes needed to pass that should be marked as dependencies? I suspect there's at least minor format updates?
0f73291
to
95d9303
Compare
42a5fde
to
7d97ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note Ubuntu 20.04 default (if you just install clang-format) is version 10.0.0, which is the same as clang-format-10. If you go to 12, you'll need to update all the impacted repos to avoid CI failures from the switch. Seems like it's easier to just stick w/ 10 for Ubuntu 20.04?
I think the cppcheck workflow failed for at least osal with Ubuntu 20.04, but should probably check them all. |
7d97ef0
to
7be4a44
Compare
7be4a44
to
c66839c
Compare
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
*Combines:* cfe v7.0.0-rc4+dev201 osal v6.0.0-rc4+dev147 **Includes:** *cFS* - #594 - #559 *cFE* - nasa/cFE#2184 *osal* - nasa/osal#1319 Co-authored by: Ariel Adams <arielsadamsnasa@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Haven Carlson <havencarlson@users.noreply.github.com>
Checklist (Please check before submitting)
Describe the contribution
Fix #554, update OS versions in github workflows
Testing performed
Check workflow results after pushing
Expected behavior changes
no impact to behavior
System(s) tested on
Browser
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA