Jk/cumulus 3785 2 #3702
Merged
Jk/cumulus 3785 2 #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super Constructor: When calling the super(message) constructor, it's better to pass a more descriptive message, like "CumulusApiClientError: " + message, so that when you catch this error, you'll immediately know what type of error it is without having to inspect the class name.
…ot provided the implementation for this function. Ensure that it handles errors correctly. In the getPrivateKey() method, KMS.decryptBase64String(fetchedKey) is used, but it appears the result isn't awaited. If decryptBase64String is asynchronous, you need to use await. Encryption & Decryption: decrypt is imported and used, but you have not provided the implementation for this function. Ensure that it handles errors correctly. In the getPrivateKey() method, KMS.decryptBase64String(fetchedKey) is used, but it appears the result isn't awaited. If decryptBase64String is asynchronous, you need to use await.
This reverts commit 10d3166.
paulpilone
approved these changes
Jul 8, 2024
paulpilone
reviewed
Jul 8, 2024
| @@ -14,7 +14,7 @@ const { s3 } = require('@cumulus/aws-client/services'); | |||
| * @param {Object} res - express response object | |||
| * @returns {Promise<Object>} the promise of express response object | |||
| */ | |||
| async function handleGetRequst(req, res) { | |||
| async function handleGetRequest(req, res) { | |||
There was a problem hiding this comment.
Is this called anywhere else (e.g. a test?) that might also need updating?
There was a problem hiding this comment.
I verified the refactor in the Core codebase (text search for references) - I don't believe it's used in the dashboard directly.
This was referenced Jul 15, 2024
Closed
Jkovarik
commented
Jul 18, 2024
| @@ -188,6 +188,13 @@ to update to at least [cumulus-ecs-task:2.1.0](https://hub.docker.com/layers/cum | |||
| - **CUMULUS-3606** | |||
| - Updated with additional documentation covering tunneling configuration | |||
| using a PKCS11 provider | |||
| - **CUMULUS-3700** | |||
Jkovarik
added a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-3785
Changes
This PR includes contributions from the following user PRs:
#3485
#3590
#3628
#3685
in addition to minor corrections/CHANGELOG updates from me/the team.
PR Checklist